Show better error message when license checking fails #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artur-
force-pushed
the
better-license-errors
branch
7 times, most recently
from
fdc4535
to
299c1e8
Compare
Artur-
force-pushed
the
better-license-errors
branch
from
397c118
to
8f28949
Compare
|
Review status: 0 of 5 files reviewed at latest revision, 1 unresolved discussion. vaadin-testbench-core/src/main/java/com/vaadin/testbench/tools/LicenseChecker.java, line 56 at r1 (raw file): Quoted 4 lines of code…> if (e.info != null && e.info.getMessage() != null) { > getLogger().log(Level.FINE, e.info.getMessage()); > } > printAndRethrowException(e.getMessage(), e);Comments from Reviewable |
|
Reviewed 5 of 5 files at r1. Comments from Reviewable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is