Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a11y: use role="button" for all avatars #43

Closed
web-padawan opened this issue Jul 14, 2020 · 0 comments · Fixed by #48
Closed

a11y: use role="button" for all avatars #43

web-padawan opened this issue Jul 14, 2020 · 0 comments · Fixed by #48
Assignees
Labels
a11y Accessibility issue

Comments

@web-padawan
Copy link
Member

From #10 (comment)

In my understanding it's more like a button / a group of buttons, especially if you are going to add a clicklistener or space-listener to it for interaction. (For example, to show more informations about the selected user in a dialog)

Currently, role="image" is used for avatars, except the +N avatar, which has role="button". This is confusing.
We should consider using role="button" for all the avatars consistently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant