refactor: only run license checker when needed #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarezguille
approved these changes
Nov 13, 2019
web-padawan
commented
Nov 13, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
manolo
pushed a commit
to vaadin/flow-components
that referenced
this pull request
Oct 3, 2020
vaadin/vaadin-board#125 * Bump parent version * Bump project version Flow-component: vaadin-board
manolo
pushed a commit
to vaadin/flow-components
that referenced
this pull request
Oct 3, 2020
vaadin/vaadin-board#125 * Bump parent version * Bump project version Flow-component: vaadin-board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to vaadin/components-team-tasks#492
This PR makes sure the license checker is only called when the component is created.
The static
_finalizeClassmethod is needed to ensure we call it once per class.This change is