Skip to content

Commit

Permalink
fix(lumo): make icon theme respect tertiary-inline (#134)
Browse files Browse the repository at this point in the history
  • Loading branch information
web-padawan committed Jul 22, 2019
1 parent 5ef0206 commit fe5feb8
Show file tree
Hide file tree
Showing 6 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions test/visual/icons.html
Original file line number Diff line number Diff line change
Expand Up @@ -65,4 +65,8 @@ <h2>Icons and size presets</h2>
<span>Icon suffix</span>
<iron-icon slot="suffix" icon="lumo:arrow-right"></iron-icon>
</vaadin-button>

<vaadin-button theme="icon tertiary-inline">
<iron-icon icon="lumo:edit"></iron-icon>
</vaadin-button>
</body>
Binary file modified test/visual/screens/vaadin-button/icons-lumo/default/chrome.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified test/visual/screens/vaadin-button/icons-lumo/default/firefox.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified test/visual/screens/vaadin-button/icons-material/default/chrome.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion theme/lumo/vaadin-button-styles.html
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@

/* Icon-only */

:host([theme~="icon"]) {
:host([theme~="icon"]:not([theme~="tertiary-inline"])) {
min-width: var(--lumo-button-size);
padding-left: calc(var(--lumo-button-size) / 4);
padding-right: calc(var(--lumo-button-size) / 4);
Expand Down

0 comments on commit fe5feb8

Please sign in to comment.