Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Lumo Theme demo to Theme Variants #92

Merged
merged 1 commit into from
Jun 18, 2018
Merged

Rename Lumo Theme demo to Theme Variants #92

merged 1 commit into from
Jun 18, 2018

Conversation

samiheikki
Copy link
Contributor

@samiheikki samiheikki commented Jun 16, 2018 •
edited by limonte
Loading

Connects to "Guidelines for component examples": "Avoid using product specific names or words that do not describe the contents of the category"

This change is Reviewable

@coveralls
Copy link

coveralls commented Jun 16, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 845

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 834: 0.0%
Covered Lines: 18
Relevant Lines: 18
💛 - Coveralls

@limonte
Copy link
Contributor

limonte commented Jun 18, 2018

:lgtm:

Reviewed 2 of 2 files at r1.
Review status: :shipit: complete! all files reviewed, all discussions resolved

Comments from Reviewable

@limonte limonte merged commit 548570f into master Jun 18, 2018
@limonte limonte removed the in review label Jun 18, 2018
@samiheikki samiheikki deleted the fix/rename-styling-demos branch June 18, 2018 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@samiheikki @coveralls @limonte @tomivirkki