This repository has been archived by the owner on Oct 8, 2020. It is now read-only.
Add API to set globalOptions #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tulioag
suggested changes
Jun 9, 2020
| * @return the ChartOptions instance connected to the given UI | ||
| */ | ||
| public static ChartOptions get(UI ui) { | ||
| ChartOptions optioner = ComponentUtil.getData(ui, ChartOptions.class); |
There was a problem hiding this comment.
How about naming the variable options ?
There was a problem hiding this comment.
Name was legacy from charts 4, but it's internal, done
| protected ChartOptions() { | ||
| } | ||
|
|
||
| JreJsonFactory getJsonFactory() { |
There was a problem hiding this comment.
changed, I tried to use the one from Charts first, then messed it up
Add sample test for json serialization
Merged
tulioag
approved these changes
Jun 10, 2020
manolo
pushed a commit
to vaadin/flow-components
that referenced
this pull request
Oct 5, 2020
vaadin/vaadin-charts-flow#357 Fixes: Web-component: vaadin-charts
manolo
pushed a commit
to vaadin/flow-components
that referenced
this pull request
Oct 6, 2020
vaadin/vaadin-charts-flow#357 Fixes: Web-component: vaadin-charts
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #332