Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use multi property observers #477

Merged
merged 2 commits into from
May 13, 2020
Merged

refactor: use multi property observers #477

merged 2 commits into from
May 13, 2020

Conversation

web-padawan
Copy link
Member

No description provided.

@web-padawan web-padawan self-assigned this May 13, 2020
DiegoCardoso
DiegoCardoso approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@DiegoCardoso DiegoCardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small findings, but overall LGTM 🥇

src/vaadin-chart.html Show resolved Hide resolved
src/vaadin-chart-series.html Show resolved Hide resolved
@web-padawan
Copy link
Member Author

@DiegoCardoso Thanks, will fix duplicate instanceof in a separate PR. Merging this one.

@web-padawan web-padawan merged commit 62658ca into master May 13, 2020
@web-padawan web-padawan deleted the oberserver branch May 13, 2020 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiegoCardoso DiegoCardoso DiegoCardoso approved these changes

Assignees

@web-padawan web-padawan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@web-padawan @DiegoCardoso