fix: reduce chart re-draws for update() #584

vursen · 2021-10-08T12:29:28Z

Description

This PR backports the fix introduced in vaadin/web-components#2508 to reduce the number of chart re-draws for the update() method.

Type of change

Bugfix

Checklist

I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
I have added a description following the guideline.
The issue is created in the corresponding repository and I have referenced it.
I have added tests to ensure my change is effective and works as intended.
New and existing tests are passing locally with my change.
I have performed self-review and corrected misspellings.

CLAassistant · 2021-10-08T12:29:32Z

All committers have signed the CLA.

hdamr · 2021-10-12T13:29:47Z

src/vaadin-chart.html

          }
        }

-        __updateOrAddSeriesInstance(seriesOptions, position) {
+        __updateOrAddSeriesInstance(seriesOptions, position, redraw) {


There is another call to this method on line 1019 that needs to be updated.

It is a bit beyond the scope of the current fix so I would rather not change the __addSeries method in this PR, but do it in a separate PR when backporting vaadin/web-components#2348. 👍

Done in #585.

refactor: reduce chart redraws for update()

2c3529d

vursen changed the title ~~refactor: reduce chart redraws for update()~~ refactor: reduce chart re-draws for update() Oct 8, 2021

vursen requested a review from yuriy-fix October 8, 2021 12:32

fix: attach afterNextRender callback to chart element

3eb0e8f

vursen changed the title ~~refactor: reduce chart re-draws for update()~~ refactor: reduce chart re-draws for update() (vaadin/web-components#2508) Oct 11, 2021

vursen changed the title ~~refactor: reduce chart re-draws for update() (vaadin/web-components#2508)~~ refactor: reduce chart re-draws for update() (#2508) Oct 11, 2021

vursen changed the title ~~refactor: reduce chart re-draws for update() (#2508)~~ refactor: reduce chart re-draws for update() Oct 11, 2021

vursen added 3 commits October 11, 2021 10:22

fix: try to fix tests

765aa90

fix: use beforeNextRender instead of afterNextRender

80d7e41

test: use calledOnce instead of callCount

ef09b32

vursen requested a review from hdamr October 12, 2021 12:19

hdamr reviewed Oct 12, 2021

View reviewed changes

vursen changed the title ~~refactor: reduce chart re-draws for update()~~ fix: reduce chart re-draws for update() Oct 13, 2021

vursen requested a review from hdamr October 13, 2021 07:30

hdamr previously approved these changes Oct 13, 2021

View reviewed changes

vursen mentioned this pull request Oct 13, 2021

fix: reduce charts initialization time up to ~2x #585

Merged

7 tasks

fix: align backport with the original implementation

ba59d8a

vursen dismissed hdamr’s stale review via ba59d8a October 13, 2021 08:10

yuriy-fix approved these changes Oct 13, 2021

View reviewed changes

vursen merged commit 6d2f8b9 into master Oct 13, 2021

vursen deleted the perf/charts/optimize-update-configuration branch October 13, 2021 12:17

vursen mentioned this pull request Oct 20, 2021

moving a multi-series chart from one component to another crush the browser vaadin/flow-components#937

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: reduce chart re-draws for update() #584

fix: reduce chart re-draws for update() #584

vursen commented Oct 8, 2021 •

edited

CLAassistant commented Oct 8, 2021 •

edited

hdamr Oct 12, 2021 •

edited

vursen Oct 12, 2021 •

edited

vursen Oct 13, 2021

fix: reduce chart re-draws for update() #584

fix: reduce chart re-draws for update() #584

Conversation

vursen commented Oct 8, 2021 • edited

Description

Type of change

Checklist

CLAassistant commented Oct 8, 2021 • edited

hdamr Oct 12, 2021 • edited

Choose a reason for hiding this comment

vursen Oct 12, 2021 • edited

Choose a reason for hiding this comment

vursen Oct 13, 2021

Choose a reason for hiding this comment

vursen commented Oct 8, 2021 •

edited

CLAassistant commented Oct 8, 2021 •

edited

hdamr Oct 12, 2021 •

edited

vursen Oct 12, 2021 •

edited