fix: remove check for unsupported type

vaadin · May 29, 2020 · 872ebfb · 872ebfb
1 parent 97105f7
commit 872ebfb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 9 deletions.
diff --git a/src/vaadin-checkbox-group.html b/src/vaadin-checkbox-group.html
@@ -339,17 +339,17 @@
 
         /** @private */
         _labelChanged(label) {
-          this._setOrToggleAttribute('has-label', label === 0 || !!label);
+          this._setOrToggleAttribute('has-label', !!label);
         }
 
         /** @private */
         _errorMessageChanged(errorMessage) {
-          this._setOrToggleAttribute('has-error-message', errorMessage === 0 || !!errorMessage);
+          this._setOrToggleAttribute('has-error-message', !!errorMessage);
         }
 
         /** @private */
         _helperTextChanged(helperText) {
-          this._setOrToggleAttribute('has-helper', helperText === 0 || !!helperText);
+          this._setOrToggleAttribute('has-helper', !!helperText);
         }
 
         /** @private */
@@ -401,7 +401,7 @@
           // The filter is added due to shady DOM triggering this slotchange event on helperText prop change
           this._hasSlottedHelper = slottedNodes.filter(node => node.nodeType !== 3).length > 0;
 
-          this._setOrToggleAttribute('has-helper', this._hasSlottedHelper ? 'slotted' : this.helperText === 0 || !!this.helperText);
+          this._setOrToggleAttribute('has-helper', this._hasSlottedHelper ? 'slotted' : !!this.helperText);
         }
 
         /** @private */

diff --git a/test/vaadin-checkbox-group_test.html b/test/vaadin-checkbox-group_test.html
@@ -352,11 +352,6 @@
         expect(vaadinCheckboxGroup.hasAttribute('has-helper')).to.be.false;
       });
 
-      it('setting number helper updates has-helper attribute', function() {
-        vaadinCheckboxGroup.helperText = 0;
-        expect(vaadinCheckboxGroup.hasAttribute('has-helper')).to.be.true;
-      });
-
       it('field with slotted helper updates has-helper attribute', function() {
         const checkboxGroupWithSlottedHelper = fixture('default-with-slotted-helper');
         checkboxGroupWithSlottedHelper._observer.flush();