fix: do not focus the field on helper element click (#205)

cherry pick of vaadin/web-components#2232 for v14 cherry pick of vaadin/web-components#2256 for v14 Fixes vaadin/flow-components#955
vaadin · Jul 21, 2021 · 94a4af5 · 94a4af5
1 parent db608ec
commit 94a4af5
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/vaadin-checkbox-group.html b/src/vaadin-checkbox-group.html
@@ -51,7 +51,6 @@
       </div>
 
       <div part="helper-text"
-        on-click="focus"
         aria-live="assertive"
         aria-hidden$="[[_getHelperTextAriaHidden(helperText, _hasSlottedHelper)]]">
         <slot name="helper">[[helperText]]</slot>

diff --git a/test/vaadin-checkbox-group_test.html b/test/vaadin-checkbox-group_test.html
@@ -377,6 +377,16 @@
 
         expect(radioButtonGroupWithSlottedHelper.hasAttribute('has-helper')).to.be.false;
       });
+
+      it('should not get focus after helper click', () => {
+        const group = fixture('default-with-slotted-helper');
+        const spy = sinon.spy(group, 'focus');
+        const helper = group.querySelector('[slot="helper"]');
+
+        helper.click();
+
+        expect(spy.called).to.be.false;
+      });
     });
   });