Merge 6601b63 into 00f403c

vaadin · Mar 19, 2019 · f47386e · f47386e
2 parents 00f403c + 6601b63
commit f47386e
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 1 deletion.
diff --git a/src/vaadin-checkbox.html b/src/vaadin-checkbox.html
@@ -309,7 +309,7 @@
 
         _toggleChecked() {
           this.checked = !this.checked;
-          this.dispatchEvent(new CustomEvent('change', {composed: true, bubbles: true}));
+          this.dispatchEvent(new CustomEvent('change', {composed: false, bubbles: true}));
         }
 
         /**

diff --git a/test/vaadin-checkbox-group_test.html b/test/vaadin-checkbox-group_test.html
@@ -210,6 +210,14 @@
       expect(vaadinCheckboxList[0].checked).to.be.false;
     });
 
+    it('should not fire change event on programmatic value change', () => {
+      const spy = sinon.spy();
+      vaadinCheckboxGroup.addEventListener('change', spy);
+
+      vaadinCheckboxGroup.value = ['2'];
+
+      expect(spy).to.not.be.called;
+    });
   });
 
   describe('vaadin-checkbox-group validation', () => {

diff --git a/test/vaadin-checkbox_test.html b/test/vaadin-checkbox_test.html
@@ -334,6 +334,26 @@
         vaadinCheckbox.addEventListener('change', () => done());
         vaadinCheckbox.click();
       });
+
+      it('should bubble', () => {
+        const spy = sinon.spy();
+        vaadinCheckbox.addEventListener('change', spy);
+
+        vaadinCheckbox.click();
+
+        const event = spy.getCall(0).args[0];
+        expect(event).to.have.property('bubbles', true);
+      });
+
+      it('should not be composed', () => {
+        const spy = sinon.spy();
+        vaadinCheckbox.addEventListener('change', spy);
+
+        vaadinCheckbox.click();
+
+        const event = spy.getCall(0).args[0];
+        expect(event).to.have.property('composed', false);
+      });
     });
 
     describe('iron-form-checkbox', () => {