Skip to content
This repository has been archived by the owner on Apr 6, 2022. It is now read-only.

Commit

Permalink
Avoid calling DataProvider::size when it's not needed (#230)
Browse files Browse the repository at this point in the history
Now it is not called when using a lazy data provider, because
- the size is used to check if client-side filtering can be used
- lazy data providers always handle filtering in server-side anyway

Fix #222
  • Loading branch information
pekam committed Mar 21, 2019
1 parent c8fb830 commit e9b6c4d
Showing 1 changed file with 2 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -520,9 +520,8 @@ public <C> void setDataProvider(DataProvider<T, C> dataProvider,
}

private void refreshAllData(boolean forceServerSideFiltering) {
int size = getDataProvider().size(new Query<>());
setClientSideFilter(
!forceServerSideFiltering && size <= getPageSizeDouble());
setClientSideFilter(!forceServerSideFiltering && getDataProvider()
.size(new Query<>()) <= getPageSizeDouble());

reset();
}
Expand Down

0 comments on commit e9b6c4d

Please sign in to comment.