This repository has been archived by the owner on Apr 6, 2022. It is now read-only.
Set value-property with js as a workaround #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the BFP: vaadin/flow#4862 In a certain scenario with PolymerTemplates, the property is not set in the client-side.
|
SonarQube analysis reported 3 issues Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
bogdanudrescu
approved these changes
Jan 14, 2019
There was a problem hiding this comment.
Reviewable status: 0 of 10 files reviewed, all discussions resolved (waiting on @pekam)
bogdanudrescu
approved these changes
Jan 14, 2019
There was a problem hiding this comment.
Reviewed 10 of 10 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @pekam)
ujoni
pushed a commit
that referenced
this pull request
Feb 8, 2019
* Add test for bfp flow/4862 * Set value-property with js as a workaround For the BFP: vaadin/flow#4862 In a certain scenario with PolymerTemplates, the property is not set in the client-side. * Add newlines
Merged
ujoni
pushed a commit
that referenced
this pull request
Feb 11, 2019
* Add test for bfp flow/4862 * Set value-property with js as a workaround For the BFP: vaadin/flow#4862 In a certain scenario with PolymerTemplates, the property is not set in the client-side. * Add newlines
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the BFP: vaadin/flow#4862
In a certain scenario with PolymerTemplates, the property is not set in
the client-side.
This change is