Fix calling render() before first open to not throw

vaadin · Mar 12, 2019 · 64d269f · 64d269f
1 parent 41f8709
commit 64d269f
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/src/vaadin-combo-box-mixin.html b/src/vaadin-combo-box-mixin.html
@@ -273,7 +273,9 @@
      * Manually invoke existing renderer.
      */
     render() {
-      this.$.overlay._selector.querySelectorAll('vaadin-combo-box-item').forEach(item => item._render());
+      if (this.$.overlay._selector) {
+        this.$.overlay._selector.querySelectorAll('vaadin-combo-box-item').forEach(item => item._render());
+      }
     }
 
     _setTemplateFromNodes(nodes) {

diff --git a/test/vaadin-combo-box.html b/test/vaadin-combo-box.html
@@ -371,6 +371,18 @@
         });
       });
     });
+
+    describe('Methods', () => {
+      let comboBox;
+
+      beforeEach(() => {
+        comboBox = fixture('combobox');
+      });
+
+      it('should not throw if render() called before opening', () => {
+        expect(() => comboBox.render()).not.to.throw(Error);
+      });
+    });
   </script>
 
 </body>