fix: do not throw when calling render() before first open (#781)

vaadin · Mar 13, 2019 · e6c299d · e6c299d
1 parent ecc226e
commit e6c299d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/vaadin-combo-box-mixin.html b/src/vaadin-combo-box-mixin.html
@@ -273,7 +273,9 @@
      * Manually invoke existing renderer.
      */
     render() {
-      this.$.overlay._selector.querySelectorAll('vaadin-combo-box-item').forEach(item => item._render());
+      if (this.$.overlay._selector) {
+        this.$.overlay._selector.querySelectorAll('vaadin-combo-box-item').forEach(item => item._render());
+      }
     }
 
     _setTemplateFromNodes(nodes) {

diff --git a/test/item-renderer.html b/test/item-renderer.html
@@ -80,6 +80,10 @@
         comboBox.render();
         expect(comboBox.renderer.callCount).to.be.equal(renderedCount * 2);
       });
+
+      it('should not throw if render() called before opening', () => {
+        expect(() => comboBox.render()).not.to.throw(Error);
+      });
     });
 
     describe('with template', () => {