-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the flaky test #731
Comments
There are currently at least 4 different tests that can fail depending on viewport height. These 2 tests fail with timeout when viewport height >= 749 px:
Fails with assertion failure when viewport height <= 166 px:
Fails with assertion failure when viewport height <= 499 px:
This means that atm. all tests can pass only if viewport height is in the range 500–748 px. (tested with Chrome 74 on macOS 10.14.5) |
The failure of these two:
seems to be an actual bug. I opened a new issue about it here with more details: #815. |
Just noticed that it's not only about viewport height but also viewport width plays some role in these failures. E.g. on Chrome with DPR 2.2 the above |
Description
Test is flaky on smaller screen.
Expected outcome
Works the same way on all screens.
Actual outcome
Not working on MBP screen.
![screen shot 2018-10-08 at 11 42 20](https://user-images.githubusercontent.com/29372419/46599310-a4762200-caef-11e8-98b3-e6236ba7d412.png)
Live Demo
https://cdn.vaadin.com/vaadin-combo-box/4.2.0-alpha4/test/
Steps to reproduce
Browsers Affected
The text was updated successfully, but these errors were encountered: