Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the flaky test #731

Closed
1 of 7 tasks
yuriy-fix opened this issue Oct 8, 2018 · 3 comments · Fixed by #816
Closed
1 of 7 tasks

Fix the flaky test #731

yuriy-fix opened this issue Oct 8, 2018 · 3 comments · Fixed by #816
Assignees
Projects

Comments

@yuriy-fix
Copy link
Contributor

Description

Test is flaky on smaller screen.

Expected outcome

Works the same way on all screens.

Actual outcome

Not working on MBP screen.
screen shot 2018-10-08 at 11 42 20

Live Demo

https://cdn.vaadin.com/vaadin-combo-box/4.2.0-alpha4/test/

Steps to reproduce

  1. Open the test page.
  2. Wait till test will fail.

Browsers Affected

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE 11
  • iOS Safari
  • Android Chrome
@jtomass jtomass added this to 📬  Inbox in vaadin-core Mar 29, 2019
@Haprog Haprog self-assigned this Jun 5, 2019
@Haprog
Copy link
Contributor

Haprog commented Jun 5, 2019

There are currently at least 4 different tests that can fail depending on viewport height.

These 2 tests fail with timeout when viewport height >= 749 px:

  • keyboard.html > keyboard navigation > scrolling items > should scroll to focused item when opening overlay
  • scrolling.html > scrolling > scrolling position > should make selected item visible after open

Fails with assertion failure when viewport height <= 166 px:

  • keyboard.html > keyboard navigation > sanity checks for calculating visible item counts > should calculate items correctly when all items are visible

Fails with assertion failure when viewport height <= 499 px:

  • filtering.html > filtering items > setting items when opened > should properly display all items in the selector

This means that atm. all tests can pass only if viewport height is in the range 500–748 px.

(tested with Chrome 74 on macOS 10.14.5)

@Haprog
Copy link
Contributor

Haprog commented Jun 10, 2019

The failure of these two:

  • keyboard.html > keyboard navigation > scrolling items > should scroll to focused item when opening overlay
  • scrolling.html > scrolling > scrolling position > should make selected item visible after open

seems to be an actual bug. I opened a new issue about it here with more details: #815.

@Haprog
Copy link
Contributor

Haprog commented Jun 10, 2019

Just noticed that it's not only about viewport height but also viewport width plays some role in these failures. E.g. on Chrome with DPR 2.2 the above filtering.html test fails also on viewport height 512px when the viewport width is less than 900px.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
vaadin-core
  
📬  Inbox
Development

Successfully merging a pull request may close this issue.

2 participants