Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ITs #965

Closed
yuriy-fix opened this issue Nov 3, 2020 · 0 comments · Fixed by vaadin/flow-components#365
Closed

Fix ITs #965

yuriy-fix opened this issue Nov 3, 2020 · 0 comments · Fixed by vaadin/flow-components#365
Assignees
@yuriy-fix
Labels
flow

Comments

@yuriy-fix
Copy link
Contributor

There are test failures caused by the latest WC updates in 5.4.4 (e768ef1 and 46a688f)
Screen Shot 2020-11-03 at 10 20 47
@yuriy-fix yuriy-fix added the flow label Nov 3, 2020
@yuriy-fix yuriy-fix self-assigned this Nov 3, 2020
@yuriy-fix yuriy-fix mentioned this issue Nov 4, 2020
Merged
yuriy-fix added a commit to vaadin/flow-components that referenced this issue Nov 4, 2020
@yuriy-fix
fix: update combo-box integration tests
fde7c08 
Web-component: combo-box

Fixes: vaadin/vaadin-combo-box#965

Details: Initially test for item count wasn't waiting for the filter to be updated with added item to get 1 and later on 251 on opening; with the update of 5.4.4 wc overlay is closed when there is no items filter, so `customItemFilter` test should be updated as well.
yuriy-fix added a commit to vaadin/flow-components that referenced this issue Nov 4, 2020
@yuriy-fix
fix: update combo-box integration tests
6874f42 
Web-component: combo-box

Fixes: vaadin/vaadin-combo-box#965

Details: Initially test for item count wasn't waiting for the filter to be updated with added item to get 1 and later on 251 on opening; with the update of 5.4.4 wc overlay is closed when there is no items filter, so `customItemFilter` test should be updated as well.
@yuriy-fix yuriy-fix mentioned this issue Nov 4, 2020
Merged
yuriy-fix added a commit to vaadin/flow-components that referenced this issue Nov 6, 2020
@yuriy-fix
fix: update combo-box integration tests
d1da9ec 
Web-component: combo-box

Fixes: vaadin/vaadin-combo-box#965

Details: with the update of 5.4.4 wc overlay is closed when there is no items filter, so `customItemFilter` test should be updated as well.
yuriy-fix added a commit to vaadin/flow-components that referenced this issue Nov 6, 2020
@yuriy-fix
fix: update combo-box integration tests
4982e3a 
Web-component: combo-box

Fixes: vaadin/vaadin-combo-box#965

Details: with the update of 5.4.4 wc overlay is closed when there is no items filter, so `customItemFilter` test should be updated as well.
yuriy-fix added a commit to vaadin/flow-components that referenced this issue Nov 9, 2020
@yuriy-fix
fix: update combo-box integration tests (#365)
c0eded0 
Web-component: combo-box

Fixes: vaadin/vaadin-combo-box#965

Details: with the update of 5.4.4 wc overlay is closed when there is no items filter, so `customItemFilter` test should be updated as well.
ZheSun88 pushed a commit to vaadin/flow-components that referenced this issue Nov 10, 2020
@yuriy-fix @ZheSun88
fix: update combo-box integration tests (#365)
873eaa2 
Web-component: combo-box

Fixes: vaadin/vaadin-combo-box#965

Details: with the update of 5.4.4 wc overlay is closed when there is no items filter, so `customItemFilter` test should be updated as well.
@ZheSun88 ZheSun88 mentioned this issue Nov 10, 2020
Merged
ZheSun88 pushed a commit to vaadin/flow-components that referenced this issue Nov 10, 2020
@yuriy-fix @ZheSun88
fix: update combo-box integration tests (#365)
64525bd 
Web-component: combo-box

Fixes: vaadin/vaadin-combo-box#965

Details: with the update of 5.4.4 wc overlay is closed when there is no items filter, so `customItemFilter` test should be updated as well.
@ZheSun88 ZheSun88 mentioned this issue Nov 10, 2020
Merged
manolo pushed a commit to vaadin/flow-components that referenced this issue Nov 10, 2020
@ZheSun88 @yuriy-fix
fix: update combo-box integration tests (#383)
91dc7c8 
Web-component: combo-box

Fixes: vaadin/vaadin-combo-box#965

Details: with the update of 5.4.4 wc overlay is closed when there is no items filter, so `customItemFilter` test should be updated as well.

Co-authored-by: Yuriy Yevstihnyeyev <yuriy@vaadin.com>
manolo pushed a commit to vaadin/flow-components that referenced this issue Nov 10, 2020
@ZheSun88 @yuriy-fix
fix: update combo-box integration tests (#365) (#384)
a105b8e 
Web-component: combo-box

Fixes: vaadin/vaadin-combo-box#965

Details: with the update of 5.4.4 wc overlay is closed when there is no items filter, so `customItemFilter` test should be updated as well.

Co-authored-by: Yuriy Yevstihnyeyev <yuriy@vaadin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuriy-fix yuriy-fix

Labels
flow
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: update combo-box integration tests vaadin/flow-components
1 participant
@yuriy-fix