Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set hasValue readOnly. Fixes #393 #394

Merged
merged 1 commit into from
Feb 9, 2017
Merged

Conversation

manolo
Copy link
Member

@manolo manolo commented Feb 9, 2017

This change is Reviewable

@platosha
Copy link
Contributor

platosha commented Feb 9, 2017

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


test/vaadin-combo-box-properties.html, line 89 at r1 (raw file):

      describe('hasValue property', function() {
        it('should be readOnly', function() {
          expect(comboBox.hasValue).to.be.false;

Should we test <vaadin-combo-box-light> as well?


Comments from Reviewable

@manolo
Copy link
Member Author

manolo commented Feb 9, 2017

Review status: all files reviewed at latest revision, 1 unresolved discussion.


test/vaadin-combo-box-properties.html, line 89 at r1 (raw file):

Previously, platosha (Anton Platonov) wrote…

Should we test <vaadin-combo-box-light> as well?

Well, changes are in ComboBoxBehavior which is implemented by both.
Since what we are testing is the implementation, using any element must work to be sure that the code is correct.
I would test in both if the code is repeated, or there was some kind of overriding of the behaviour.


Comments from Reviewable

@platosha
Copy link
Contributor

platosha commented Feb 9, 2017

:lgtm:


Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

@limonte
Copy link
Contributor

limonte commented Feb 9, 2017

:lgtm:


Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

@platosha platosha merged commit ab19f19 into master Feb 9, 2017
@platosha platosha deleted the fix/hasvalue-readonly branch February 9, 2017 12:21
@platosha platosha removed the in review label Feb 9, 2017
manolo pushed a commit to vaadin/vaadin-combo-box-flow that referenced this pull request Oct 3, 2020
vaadin/vaadin-combo-box#394

Don't set value if Element has property "value"

Fixes: 


Flow-component: vaadin-combo-box
manolo pushed a commit to vaadin/vaadin-combo-box-flow that referenced this pull request Oct 3, 2020
vaadin/vaadin-combo-box#394

Don't set value if Element has property "value"

Fixes: 


Flow-component: vaadin-combo-box
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants