Fix/opened when no items

[manolo]

Fixes vaadin/vaadin-time-picker#58

---

This change is 

[yuriy-fix]

Seems not to be working with custom values in combo-box.
Tests are failing.

Reviewable status: 0 of 2 files reviewed, all discussions resolved

[yuriy-fix]

Reviewed 2 of 2 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved

[yuriy-fix]

Please check the tests and functionality with custom value.

[coveralls]

Pull Request Test Coverage Report for Build 3379

• 5 of 5 (100.0%) changed or added relevant lines in 2 files are covered.
• 3 unchanged lines in 2 files lost coverage.
• Overall coverage decreased (-0.5%) to 90.579%

---

Files with Coverage Reduction	New Missed Lines	%
src/vaadin-combo-box-dropdown.html	1	97.35%
src/vaadin-combo-box-dropdown-wrapper.html	2	76.76%

Totals
Change from base Build 3377:	-0.5%
Covered Lines:	477
Relevant Lines:	505

---

💛 - Coveralls

[manolo]

@yuriyvaadin changed the implementation in order not to break tests

Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on @YuriyVaadin)

[web-padawan]

Reviewed 4 of 4 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @manolo)

---

src/vaadin-combo-box-dropdown-wrapper.html, line 158 at r2 (raw file):

      _itemsChanged(items) {
        if (this.opened && !this.$.dropdown.opened && items && items.length) {

should we refactor these 2 new observers and use a multi-property observer for opened and _items instead?
Polymer docs require us to always list every dependency as an argument to the observer

[manolo]

Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @web-padawan)

---

src/vaadin-combo-box-dropdown-wrapper.html, line 158 at r2 (raw file):

Previously, web-padawan (Sergey Kulikov) wrote…

should we refactor these 2 new observers and use a multi-property observer for opened and _items instead?
Polymer docs require us to always list every dependency as an argument to the observer

Done.

[web-padawan]

Reviewed 1 of 1 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @manolo)

a discussion (no related file):
With this change, now it seems that the notify: true here is not needed anymore and can be removed: https://github.com/vaadin/vaadin-combo-box/blob/master/src/vaadin-combo-box-dropdown.html#L66

---

[yuriy-fix]

Nit: should combo-box itself still become opened?

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @manolo)

[manolo]

Yes it's is opened because developer called open(), but the overlay is not attached.
If we want to change this behaviour like I did in my first commit, we need to change a lot of tests and code.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @manolo)

[manolo]

Reviewable status: 4 of 6 files reviewed, 1 unresolved discussion (waiting on @web-padawan)

a discussion (no related file):

Previously, web-padawan (Sergey Kulikov) wrote…

With this change, now it seems that the notify: true here is not needed anymore and can be removed: https://github.com/vaadin/vaadin-combo-box/blob/master/src/vaadin-combo-box-dropdown.html#L66

Done.

---

[yuriy-fix]

Ok.

Reviewed 3 of 4 files at r2, 1 of 1 files at r3, 2 of 2 files at r4.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @web-padawan)

[yuriy-fix]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @web-padawan)

[web-padawan]

Reviewed 2 of 2 files at r4.
Reviewable status: complete! all files reviewed, all discussions resolved

[web-padawan]

Reviewed 3 of 3 files at r5.
Reviewable status: complete! all files reviewed, all discussions resolved