Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't throw with large size #736

Merged
merged 1 commit into from
Oct 15, 2018
Merged

Don't throw with large size #736

merged 1 commit into from
Oct 15, 2018

Conversation

tomivirkki
Copy link
Member

@tomivirkki tomivirkki commented Oct 15, 2018

This change is Reviewable

Copy link
Member

@web-padawan web-padawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @tomivirkki)

@web-padawan web-padawan merged commit 2783eb4 into master Oct 15, 2018
@web-padawan web-padawan deleted the fix/big-size-crash branch October 15, 2018 13:51
@heruan
Copy link
Member

heruan commented Oct 15, 2018

Seems like it still throws, but in a different method:

Uncaught RangeError: Maximum call stack size exceeded
    at HTMLElement.clearCache (vaadin-combo-box-data-provider-mixin.html:170)
    at Object.comboBox.$connector.reset (comboBoxConnector.js:110)
    at Object.eval (eval at jt (client-D1AD34905AC1AA5B4DBECA8FB0306D92.cache.js:972), <anonymous>:3:33)

I'll open a new issue, as this is already merged.

This was referenced Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants