Fix ComboBox Demos #836
Merged
Fix ComboBox Demos #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tomivirkki
requested changes
Sep 16, 2019
tomivirkki
force-pushed
the
ImproveComboBoxDemos
branch
from
08d6f17
to
52263e4
Compare
tomivirkki
requested changes
Sep 23, 2019
There was a problem hiding this comment.
There's some misalignment in the demos, especially between the demo id's. Examples:
- combo-box-styling-demos-custom-theme-variant (component and demo page prefix)
- combo-box-second-custom-value (component prefix)
- disabled-and-readonly (no prefix)
The no-prefix -versions might make the most sense because the context is just redundant information.
added 3 commits
September 24, 2019 12:38
tomivirkki
approved these changes
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #832