Skip to content
This repository has been archived by the owner on Oct 8, 2020. It is now read-only.

Update readme with the new link to docs and branching #21

Merged
merged 3 commits into from
Sep 24, 2018
Merged

Conversation

denis-anisimov
Copy link

@denis-anisimov denis-anisimov commented Sep 23, 2018

Part of fix for vaadin-button-flow/issues/83


This change is Reviewable

Part of fix for vaadin-button-flow/issues/83
@CLAassistant
Copy link

CLAassistant commented Sep 23, 2018

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@ZheSun88 ZheSun88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sign the CLA

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @denis-anisimov)


README.md, line 7 at r1 (raw file):

- `1.0` branch is Vaadin 10 LTS (Flow/Flow-component version 1.0)

1.0 branch should be Vaadin 10 compatible, but this component should not be LTS
same as grid 1.1 branch

Copy link
Author

@denis-anisimov denis-anisimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @ZheSun88)


README.md, line 7 at r1 (raw file):

Previously, ZheSun88 (Sun Zhe) wrote…
- `1.0` branch is Vaadin 10 LTS (Flow/Flow-component version 1.0)

1.0 branch should be Vaadin 10 compatible, but this component should not be LTS
same as grid 1.1 branch

Done.

Copy link
Contributor

@ZheSun88 ZheSun88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved


README.md, line 7 at r1 (raw file):

Previously, denis-anisimov (Denis) wrote…

Done.

mentioning (Flow version 1.0, but no LTS support)

Copy link
Contributor

@ZheSun88 ZheSun88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @denis-anisimov)

Copy link
Contributor

@ZheSun88 ZheSun88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@ZheSun88 ZheSun88 merged commit a562207 into master Sep 24, 2018
@ZheSun88 ZheSun88 deleted the 83-readme branch September 24, 2018 07:09
denis-anisimov pushed a commit that referenced this pull request Sep 24, 2018
* Update readme with the new link to docs and branching

Part of fix for vaadin-button-flow/issues/83

* Don't mention LTS for this component

* Mention that there is no LTS support
ZheSun88 pushed a commit that referenced this pull request Sep 24, 2018
* Update readme with the new link to docs and branching (#21)

* Update readme with the new link to docs and branching

Part of fix for vaadin-button-flow/issues/83

* Don't mention LTS for this component

* Mention that there is no LTS support
@elmot elmot added this to the 1.2.0 milestone Nov 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants