New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add renderer support #171
Add renderer support #171
Conversation
d7320b6
to
7ce2080
Compare
Fixes #169 Depends on vaadin/vaadin-overlay#99
7ce2080
to
2e25021
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 7 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @platosha)
test/renderer.html, line 143 at r1 (raw file):
}); it('should fallback to template if renderer is removed', () => {
In grid we only support template or renderer, hence if user wants to set a renderer must not add the template child in declarative.
Shouldn't all elements be aligned ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @platosha)
test/renderer.html, line 143 at r1 (raw file):
Previously, manolo (Manuel Carrasco Moñino) wrote…
In grid we only support template or renderer, hence if user wants to set a renderer must not add the template child in declarative.
Shouldn't all elements be aligned ?
I know this is extra, could remove, but I fell a bit better about having em here. That allows for more refined implementation in a way.
Not doing any extra in the grid is fine by me, the extra price in the grid’s case is very high.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved
test/renderer.html, line 143 at r1 (raw file):
Previously, platosha (Anton Platonov) wrote…
I know this is extra, could remove, but I fell a bit better about having em here. That allows for more refined implementation in a way.
Not doing any extra in the grid is fine by me, the extra price in the grid’s case is very high.
ok, anyways removing this could be done in different PR, not blocker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 7 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved
Fixes #169
This change is