Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add renderer support #171

Merged
merged 3 commits into from Jul 19, 2018
Merged

Add renderer support #171

merged 3 commits into from Jul 19, 2018

Conversation

platosha
Copy link
Contributor

@platosha platosha commented Jul 16, 2018

Fixes #169


This change is Reviewable

@platosha platosha force-pushed the feature/renderer branch 3 times, most recently from d7320b6 to 7ce2080 Compare July 18, 2018 12:01
Copy link
Member

@tomivirkki tomivirkki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Member

@manolo manolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @platosha)


test/renderer.html, line 143 at r1 (raw file):

        });

        it('should fallback to template if renderer is removed', () => {

In grid we only support template or renderer, hence if user wants to set a renderer must not add the template child in declarative.

Shouldn't all elements be aligned ?

Copy link
Contributor Author

@platosha platosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @platosha)


test/renderer.html, line 143 at r1 (raw file):

Previously, manolo (Manuel Carrasco Moñino) wrote…

In grid we only support template or renderer, hence if user wants to set a renderer must not add the template child in declarative.

Shouldn't all elements be aligned ?

I know this is extra, could remove, but I fell a bit better about having em here. That allows for more refined implementation in a way.

Not doing any extra in the grid is fine by me, the extra price in the grid’s case is very high.

Copy link
Member

@manolo manolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved


test/renderer.html, line 143 at r1 (raw file):

Previously, platosha (Anton Platonov) wrote…

I know this is extra, could remove, but I fell a bit better about having em here. That allows for more refined implementation in a way.

Not doing any extra in the grid is fine by me, the extra price in the grid’s case is very high.

ok, anyways removing this could be done in different PR, not blocker.

Copy link
Member

@manolo manolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Member

@manolo manolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@manolo manolo merged commit 745641a into renderer-preview Jul 19, 2018
@manolo manolo deleted the feature/renderer branch July 19, 2018 13:57
@manolo manolo removed the in review label Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants