Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary imports of text-fixture.html #194

Closed
wants to merge 1 commit into from

Conversation

limonte
Copy link
Contributor

@limonte limonte commented Oct 30, 2018

Fixes #193

There's no <link rel="import" href="../../test-fixture/test-fixture.html"> in skeleton, once this PR is approved and merged, I'm going to fix the same thing in all other components.


This change is Reviewable

Copy link
Member

@web-padawan web-padawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 9 files reviewed, 1 unresolved discussion (waiting on @limonte and @web-padawan)

a discussion (no related file):
Let's revert vaadin/vaadin-element-skeleton#165 and stick to the following order:

  <script src="../../web-component-tester/browser.js"></script>
  <script src="../../webcomponentsjs/webcomponents-lite.js"></script>
  <link rel="import" href="../../test-fixture/test-fixture.html">

Note: the Symbol polyfill issue, which happens in IE11 when placing browser.js after the polyfill, is being tracked at webcomponents/webcomponentsjs#1047


@limonte limonte force-pushed the fix/remove-test-fixture-imports branch from 7ed46fc to 50cc673 Compare November 12, 2018 08:08
@limonte limonte closed this Nov 12, 2018
@limonte limonte deleted the fix/remove-test-fixture-imports branch November 12, 2018 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Travis cron build is failing with "document.getElementById(...).create is not a function" in Firefox
2 participants