fix: ensure consistent right alignment for nested menus #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomivirkki
requested changes
Mar 25, 2019
web-padawan
force-pushed
the
fix/rightaligned
branch
3 times, most recently
from
eb8739c
to
de6ee83
Compare
web-padawan
force-pushed
the
fix/rightaligned
branch
from
de6ee83
to
561bb42
Compare
tomivirkki
approved these changes
Mar 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to vaadin/vaadin-menu-bar#17
Similar to #223 but now for right-aligned menu, so implementation is different.
Before
Submenu overlay is left-aligned:
After
Submenu overlay is also right aligned and takes parent's content width into account:
This change is