Propagate theme attribute #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomivirkki
requested changes
May 15, 2019
yuriy-fix
force-pushed
the
propagate-theme
branch
from
908c9b9
to
4eaede4
Compare
tomivirkki
requested changes
May 15, 2019
tomivirkki
requested changes
May 15, 2019
yuriy-fix
force-pushed
the
propagate-theme
branch
3 times, most recently
from
36a3e97
to
103fd97
Compare
tomivirkki
requested changes
May 15, 2019
|
The side-effect is now fixed. |
tomivirkki
requested changes
May 20, 2019
yuriy-fix
force-pushed
the
propagate-theme
branch
from
a8cc6ee
to
1ddfcad
Compare
|
Fixed and test for removal of the |
tomivirkki
approved these changes
May 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propagate theme attribute to nested overlays, list-boxes and items.
This change is