Skip to content
This repository has been archived by the owner on Apr 6, 2022. It is now read-only.

Date format got changed when reopen the date picker inside dialog(RC3) #96

Closed
jcgueriaud opened this issue Jun 12, 2018 · 5 comments · Fixed by #186
Closed

Date format got changed when reopen the date picker inside dialog(RC3) #96

jcgueriaud opened this issue Jun 12, 2018 · 5 comments · Fixed by #186
Assignees
Labels
BFP Bug fix prioritised by a customer bug Something isn't working

Comments

@jcgueriaud
Copy link

jcgueriaud commented Jun 12, 2018

#Hello,

When I set the locale to the datepicker, open a dialog the date format is correct (french format). If I close the dialog and re-open it the date format is wrong (US format)

Here a running example: https://date-tester-vaadin10.herokuapp.com/date

And the code is here: https://github.com/jcgueriaud/test/blob/master/src/main/java/com/gmail/jeanchristophe/DatePickerView.java

I tried on multiple browsers (chromium on ubuntu, firefox on ubuntu, chrome on Windows 10).

Thanks,

@denis-anisimov
Copy link

There are two totally different issues.
The one is a duplicate of vaadin/vaadin-grid-flow#122.

Another one is about datepicker date format.
Please do one of the following:

  • reformulate this issue so that it's only about one problem (date format because the other one is a duplicate)
  • close this one and create a new about date format only.

@jcgueriaud
Copy link
Author

jcgueriaud commented Jun 12, 2018

Ok I edit my 1st post and reformulate the issue.
That's quite hard to know where the issues are (inside a vaadin-grid-flow for a problem without grid).

Thanks for your fast anwser

@ZheSun88 ZheSun88 changed the title Date picker inside a popup (RC3) Date format got changed when reopen the date picker inside dialog(RC3) Jun 13, 2018
@ZheSun88
Copy link
Contributor

I have edited the title of this ticket to describe the issue. If it is not correct, feel free to change it.

@ZheSun88 ZheSun88 added bug Something isn't working components labels Jun 13, 2018
@ZheSun88 ZheSun88 added this to the 1.0 Maintenance milestone Jun 13, 2018
@jcgueriaud
Copy link
Author

Thanks for editing the title.
Date format got changed and i18n configuration got changed. (label of month ...)

@Nightbringer42
Copy link

Same problem here, with and without i18n modification.

@pleku pleku added the BFP Bug fix prioritised by a customer label May 24, 2019
@pleku pleku added this to Needs triage in OLD Vaadin Flow bugs & maintenance (Vaadin 10+) via automation May 24, 2019
@caalador caalador moved this from Needs triage to P2 - Medium Priority in OLD Vaadin Flow bugs & maintenance (Vaadin 10+) May 24, 2019
@caalador caalador moved this from P2 - Medium Priority to P1 - High priority in OLD Vaadin Flow bugs & maintenance (Vaadin 10+) May 24, 2019
@pekam pekam self-assigned this Jun 17, 2019
pekam added a commit that referenced this issue Jun 17, 2019
Flow creates a new client-side instance on re-attach, so JavaScript
needs to be executed again.

Fix #96
pekam added a commit that referenced this issue Jun 17, 2019
Flow creates a new client-side instance on re-attach, so JavaScript
needs to be executed again.

Fix #96
pekam added a commit that referenced this issue Jun 17, 2019
Flow creates a new client-side instance on re-attach, so JavaScript
needs to be executed again.

Fix #96
@pekam pekam moved this from P1 - High priority to WIP in OLD Vaadin Flow bugs & maintenance (Vaadin 10+) Jun 19, 2019
OLD Vaadin Flow bugs & maintenance (Vaadin 10+) automation moved this from WIP to Closed - pending release Jun 28, 2019
pekam added a commit that referenced this issue Jun 28, 2019
Flow creates a new client-side instance on re-attach, so JavaScript
needs to be executed again.

Fix #96
@mehdi-vaadin mehdi-vaadin moved this from Closed - pending release to Closed - released in OLD Vaadin Flow bugs & maintenance (Vaadin 10+) Sep 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
BFP Bug fix prioritised by a customer bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants