Fix aria role for calendar dates

vaadin · Oct 28, 2018 · 3111cf1 · 3111cf1
1 parent ab7ed98
commit 3111cf1
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/vaadin-month-calendar.html b/src/vaadin-month-calendar.html
@@ -329,7 +329,7 @@
         }
 
         _getRole(date) {
-          return date ? 'button' : 'presentational';
+          return date ? 'button' : 'presentation';
         }
 
         _getAriaLabel(date) {

diff --git a/test/wai-aria.html b/test/wai-aria.html
@@ -291,6 +291,15 @@
           });
         });
 
+        it('should have presentation roles on empty date cells', () => {
+          var emptyDateElements = monthCalendar.root.querySelectorAll('[part="date"]:empty');
+
+          Array.prototype.forEach.call(emptyDateElements, emptyElement => {
+            expect(emptyElement.getAttribute('role')).to.equal('presentation');
+            expect(emptyElement.getAttribute('aria-label')).to.be.empty;
+          });
+        });
+
         describe('week numbers', () => {
           beforeEach(done => {
             monthCalendar.showWeekNumbers = true;