Cleanup unused code and unnecessary DOM measurements #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
chore/perf-cleanup
branch
from
f95ef78
to
e419c22
Compare
web-padawan
force-pushed
the
chore/perf-cleanup
branch
from
e419c22
to
010c091
Compare
tomivirkki
approved these changes
Sep 3, 2018
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @web-padawan)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: removal of
IronA11yKeysBehaviorfromvaadin-combo-box-lightcan be potentially breaking change, but it is not used by component itself,nd anyone who wants to extend it can still usePolymer.mixinBehaviorshimself.This change is