Bypass default value validation by checking if value has changed #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limonte
force-pushed
the
fix/required-invalid
branch
from
9a669c0
to
12f69f2
Compare
web-padawan
changed the title
|
Polymer 3 tests are broken because of the Symbol polyfill changed in |
platosha
approved these changes
Sep 24, 2018
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, 12 of 12 files at r3.
Reviewable status:complete! all files reviewed, all discussions resolved
yuriy-fix
approved these changes
Sep 24, 2018
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, 12 of 12 files at r3.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #605
This change is