Simplify basic demos #609
Merged
Simplify basic demos #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limonte
approved these changes
Oct 2, 2018
samiheikki
force-pushed
the
fix/simplify-demos
branch
from
8417ce1
to
fbdbf46
Compare
samiheikki
commented
Oct 20, 2018
There was a problem hiding this comment.
Good point. I replaced Birthday label with few demos but left it for "pre-selected value" and "Initial position" demos as the initial date is pointing to few decades ago which is a good use case for Birthday
Reviewable status: 0 of 1 files reviewed, all discussions resolved
samiheikki
force-pushed
the
fix/simplify-demos
branch
from
fbdbf46
to
a30f556
Compare
samiheikki
force-pushed
the
fix/simplify-demos
branch
from
a30f556
to
83e22ba
Compare
yuriy-fix
approved these changes
Nov 1, 2018
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @samiheikki)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use label in all demos and remove simple examples that don't have label
This change is