-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add clear-button-visible API from <vaadin-text-field> #648
Conversation
a3ca555
to
f836e92
Compare
Should probably also bump |
f836e92
to
33cfb84
Compare
@Haprog done |
@platosha Looks like in this version when you click on the clear button, it always opens the date picker, regardless of if the date picker input was focused or not and if the overlay was open or not. This is different from current behaviour in released version. If you test it here: https://cdn.vaadin.com/vaadin-date-picker/3.3.2/demo/#date-picker-basic-demos clicking on the clear button doesn't open or close the date-picker, it just clears the value and focuses the text field. So if you click the clear button when the overlay is open, it stays open. And if you click the clear button when the overlay is closed, it stays closed. We should probably add tests for this so that the behaviour doesn't unintentionally change. So we should test what happens when the clear button is clicked in at least these cases: Clear button is clicked when:
|
Fixes #645 BREAKING CHANGE: The clear button is now hidden by default. To make it visible, set the `clear-button-visible` attribute or use `clearButtonVisible` JS API property.
33cfb84
to
c2a9ebd
Compare
Fixes #645
BREAKING CHANGE: The clear button is now hidden by default. To make it
visible, set the
clear-button-visible
attribute or useclearButtonVisible
JS API property.This change is