Run validation when field is blurred #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A focused date is always expected to be valid (the user should not be able to focus invalid dates).
|
The tests are failing at some random thing about “theme-propagation”. Doesn’t seem to be related to this change. Test pass locally in Chrome at least. |
|
One point raised by the original issue author: pressing the clear button should remove the invalid state immediately as well. Right now it is not removed, only after the user blurs the field. |
Confirmed this issue. It works with |
tomivirkki
requested changes
Oct 11, 2019
tomivirkki
approved these changes
Oct 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes vaadin/vaadin-date-picker-flow#201
If you can come up with any potential side-effects of running validation on blur, that would be great to catch before merging 🤗
This change is