Fix flipped overlay alignment with RTL #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pekam
force-pushed
the
fix-rtl-overlay-flip
branch
4 times, most recently
from
e8b284b
to
25664b1
Compare
It looks like alignment tests were removed in commit 64a2f44 and I couldn't find any substitutive cases in the current test set
because the _focus() method in control-state-mixin was recently marked as private
pekam
force-pushed
the
fix-rtl-overlay-flip
branch
from
25664b1
to
8cb6722
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #710
Also:
(see commit messages for more info)
Don't squash.