refactor: use tertiary theme for overlay buttons #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove styles applied to the buttons and use "tertiary" theme instead. Fixes #734
|
Note, screenshots are different because of Before
After
I'm not sure where does |
web-padawan
approved these changes
Oct 6, 2020
There was a problem hiding this comment.
Discussed with @jouni and agreed the change looks good.
It’s internal to our component layout, won’t affect application layouts.
If a custom theme has changed the padding, it should still work as well.
|
Though, the margins should still be removed from the buttons, now that I look closer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove styles applied to the buttons and use "tertiary" theme instead.
Fixes #734