Skip to content
This repository has been archived by the owner on Oct 8, 2020. It is now read-only.

Implement Focusable #5

Closed
Haprog opened this issue Oct 14, 2019 · 1 comment · Fixed by #9
Closed

Implement Focusable #5

Haprog opened this issue Oct 14, 2019 · 1 comment · Fixed by #9

Comments

@Haprog
Copy link
Contributor

Haprog commented Oct 14, 2019

Make DateTimePicker implement Focusable<DateTimePicker> and make sure focusing works. It should probably focus the date picker. This did not work as is when implementing #1 so need to investigate what other changes are needed to make it work. Test if focusing works on client side (may require changes to vaadin-date-time-picker).

Related comment: https://github.com/vaadin/vaadin-date-time-picker-flow/pull/4/files/13cbc490bed85d7a45e42c957e6f1811b0be72e1#r333962898

@Haprog
Copy link
Contributor Author

Haprog commented Jan 22, 2020

This might be easy to implement now that vaadin/vaadin-date-time-picker#25 is done.

Hopefully now the only thing that needs to be done for this is to add:

import com.vaadin.flow.component.Focusable;

And Focusable<DateTimePicker> into the implements section of DateTimePicker class. Then just need to test that calling dateTimePicker.focus() (e.g. from button click) actually focuses the date picker.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant