fix: add support for getting initial value from slotted fields #12
Conversation
Additionally: - Set custom field value format methods earlier (via data binding) so that the first `value-changed` event from custom field already uses the correct format (with 'T' instead of '\t') - When setting custom field value from date time picker, use `this.value` instead of `formattedValue` for more consistent formatting (to avoid unnecessarily adding `:00.000` or `.000` to end of time in more cases until we have support for `step` property which should handle this better) Fixes #11.
|
|
| this.$.customField.value = formattedValue; | ||
| // Setting the customField.value below triggers validation of the date picker and time picker. | ||
| // If the inputs are slotted (e.g. when using the Java API) and have an initial value this can | ||
| // happen before date picker ready() which triggers an error when date picker is trying to read | ||
| // `this.$.input` (as a result of value change triggered by setting custom field value). | ||
| // Workaround the problem by overriding customField.validate while setting the initial value. | ||
| if (!this.$.customField.inputs[0].$) { | ||
| const validate = this.$.customField.validate; | ||
| /* istanbul ignore next */ | ||
| this.$.customField.validate = () => true; | ||
|
|
||
| this.$.customField.value = this.value; | ||
|
|
||
| this.$.customField.validate = validate; | ||
| setTimeout(() => { | ||
| this.$.customField.validate(); | ||
| }); | ||
| } else { | ||
| this.$.customField.value = this.value; | ||
| } |
There was a problem hiding this comment.
This is kind of ugly, but I couldn't think of any nicer way to solve the problem right now. At least this seems to work and it would be good to get merged and released as alpha2 soon because it's blocking vaadin-date-time-picker-flow MVP.
Maybe this could be avoided if custom field would handle this situation automatically and not calling the validation of the inputs too early, or maybe date-picker should handle it by not trying to read the $.input if validate is called too early. I'm not sure should it be allowed to trigger validation before ready() or not.
There was a problem hiding this comment.
Just create a ticket to find a proper solution and refactoring this so we don't forget it.
There was a problem hiding this comment.
Will create an issue right after merging this so I can link to the code in master branch.
Additionally:
value-changedevent from custom field already uses the correct format (with 'T' instead of '\t')this.valueinstead offormattedValuefor more consistent formatting (to avoid unnecessarily adding:00.000or.000to end of time in more cases until we have support forstepproperty which should handle this better)Fixes #11.