Skip to content
This repository has been archived by the owner on Apr 6, 2022. It is now read-only.

Add a note that 'setWidth' sets a width to a 'flow-component-renderer', not an overlay/dialog itself #139

Closed
anasmi opened this issue Oct 8, 2019 · 1 comment

Comments

@anasmi
Copy link
Contributor

anasmi commented Oct 8, 2019

Dialog dialog = new Dialog();
dialog.add(new Label("Close me with the esc-key or an outside click"));
dialog.setWidth("80px");

Sets the width of the div inside the flow-component-renderer, but not the dialog itself

This (as turned out )is in line with the acceptance criteria of a setWidth #35 (comment)

Though, it would be nice to add a mention about this behavior to JavaDocs, since it's not what a user expects by default.

@anasmi anasmi changed the title Add a note that setWidth sets a width to a flow-component-renderer, not an overlay/dialog itself Add a note that 'setWidth' sets a width to a 'flow-component-renderer', not an overlay/dialog itself Oct 8, 2019
@web-padawan
Copy link
Member

Fixed by #147 and will be included to 2.1 minor release as a behavior altering fix.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants