Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable resizing the dialog #132

Closed
OlliTietavainenVaadin opened this issue Jul 5, 2019 · 1 comment · Fixed by #139
Closed

Enable resizing the dialog #132

OlliTietavainenVaadin opened this issue Jul 5, 2019 · 1 comment · Fixed by #139

Comments

@OlliTietavainenVaadin
Copy link
Member

There should be an optional API for toggling user resizability of the window. This should happen by dragging the dialog from the edges or the corners as usual.

@jouni
Copy link
Member

jouni commented Oct 22, 2019

Notes regarding implementation:

Must have:

  • Resizable from the bottom right corner (RTL handled later)
  • The area from where the user can start the resize should be around 20x20px and extend slightly outside the edge of the dialog
  • Mouse cursor should change when hovering on top of the corner – no other visual indication required

Should have:

  • Resizable from all edges and corners (that handles RTL)

Could have:

Details:

  • Implementation should probably use the suggested setBounds(top, right, bottom, left) in Enable dragging dialog to a new position #133
  • Once the user starts the resize, the dialog size should “snap to pixels”
  • To keep the behavior consistent together with draggable dialogs, the dialog should start using absolute positioning once the users starts to resize it (instead of flexbox based centering)
  • The user can only interact/resize with the last opened dialog when the dialog is modal
  • If the dialog is modeless, the user can resize dialogs “behind” the last opened dialog, but the dialog stacking order does not change
    • This requires a separate feature for managing the stacking order / focused dialog

API:

  • <vaadin-dialog resizable>
  • vaadinDialog.resizable = true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants