This repository has been archived by the owner on Apr 6, 2022. It is now read-only.
Fix setting dimension for opened/attached dialog #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make call to set overlay dimension on setWidth/setHeight - Add tests to cover cases the bug was present Fixes #156
tomivirkki
suggested changes
Feb 24, 2020
vaadin-dialog-flow/src/main/java/com/vaadin/flow/component/dialog/Dialog.java
Show resolved
Hide resolved
vaadin-dialog-flow/src/main/java/com/vaadin/flow/component/dialog/Dialog.java
Outdated
Show resolved
Hide resolved
- Fix minor issues with code style
tomivirkki
approved these changes
Feb 24, 2020
vaadin-bot
reviewed
Feb 24, 2020
...w-integration-tests/src/main/java/com/vaadin/flow/component/dialog/tests/DialogTestPage.java
Show resolved
Hide resolved
vaadin-bot
reviewed
Feb 24, 2020
...w-integration-tests/src/main/java/com/vaadin/flow/component/dialog/tests/DialogTestPage.java
Show resolved
Hide resolved
|
SonarQube analysis reported 5 issues
Watch the comments in this conversation to review them. 3 extra issuesNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
DiegoCardoso
added a commit
that referenced
this pull request
Feb 25, 2020
- Make call to set overlay dimension on setWidth/setHeight - Add tests to cover cases the bug was present - Set properties on default resize callback Fixes #156
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #156