Inform server that user wants to close the dialog.

[manolo]

Client-side can close the dialog synchronously when the user presses escape or
clicking outside. This makes server side unable to prevent closing if there
are unsave changes etc. With this change, server side can listen to an event
and decide whether to close the dialog.

Fixes #37

---

This change is 

[caalador]

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, some commit checks failed.

---

src/main/java/com/vaadin/flow/component/dialog/Dialog.java, line 78 at r1 (raw file):

              + "};"
              + "$0.$.overlay.addEventListener('vaadin-overlay-outside-click', f);"
              + "$0.$.overlay.addEventListener('vaadin-overlay-escape-press', f);", getElement());

For the latter part $0.$.overlay... i think you might need to postpone the execution if the polymer element hasn't yet initialised as now it would seem that it is run too early.
So I guess something like:

if(PolymerUtils:isPolymerElemnet(*)($0)) { 
  // Add event listeners
} else if (PolymerUtils::mayBePolymerElement(*)($0)){
  Window.customElements.whenDefined($0.localName).then(function () {
    // Add event listeners
  });
}

Or if there is another hook in 'vaadin-dialog' element to catch initialization complete then use that.

---

Comments from Reviewable

[manolo]

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

---

src/main/java/com/vaadin/flow/component/dialog/Dialog.java, line 78 at r1 (raw file):

Previously, caalador wrote…

For the latter part $0.$.overlay... i think you might need to postpone the execution if the polymer element hasn't yet initialised as now it would seem that it is run too early.
So I guess something like:

if(PolymerUtils:isPolymerElemnet(*)($0)) { 
  // Add event listeners
} else if (PolymerUtils::mayBePolymerElement(*)($0)){
  Window.customElements.whenDefined($0.localName).then(function () {
    // Add event listeners
  });
}

Or if there is another hook in 'vaadin-dialog' element to catch initialization complete then use that.

This was working because in bakery dialog is created in a template, hence failing when creating it in pure java.

I have moved the code to the block where the dialog is attached in java. This guarantees that the client-side element is actually enhanced and avoids adding more code to client side.

---

Comments from Reviewable

[caalador]

Reviewed 3 of 3 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable