Correctly handle request to close from client-side #91
Conversation
denis-anisimov
changed the title
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion
a discussion (no related file):
IT tests are required to make sure that JS from the server side is correctly scheduled
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion
a discussion (no related file):
Previously, denis-anisimov (Denis) wrote…
IT tests are required to make sure that JS from the server side is correctly scheduled
Not IT but unit tests for the server side
denis-anisimov
changed the title
|
SonarQube analysis reported 3 issues Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, 2 of 2 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
Fixes #80 , #68
This change is