Close the overlay on detach. Fixes #54

vaadin · Feb 27, 2018 · 5c39aa9 · 5c39aa9
1 parent 974dc3d
commit 5c39aa9
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/src/vaadin-dialog.html b/src/vaadin-dialog.html
@@ -118,6 +118,11 @@
           this.$.overlay.addEventListener('vaadin-overlay-escape-press', this._handleEscPress.bind(this));
         }
 
+        disconnectedCallback() {
+          super.disconnectedCallback();
+          this.opened = false;
+        }
+
         _openedChanged(opened) {
           if (opened && !this._instance) {
             this._contentTemplate = this.querySelector('template');

diff --git a/test/vaadin-dialog_test.html b/test/vaadin-dialog_test.html
@@ -40,6 +40,11 @@
         expect(overlay.getAttribute('role')).to.be.eql('dialog');
       });
 
+      it('overlay should close on dettach', () => {
+        dialog.parentNode.removeChild(dialog);
+        expect(dialog.opened).to.eql(false);
+      });
+
       describe('no-close-on-esc', () => {
         it('should close itself on ESC press by default', () => {
           MockInteractions.pressAndReleaseKeyOn(document.body, 27, [], 'Escape');