Call renderer when first opened

vaadin · Aug 30, 2018 · fe9560a · fe9560a
1 parent a97bac3
commit fe9560a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/src/vaadin-dialog.html b/src/vaadin-dialog.html
@@ -219,10 +219,6 @@
 
           this._oldTemplate = template;
           this._oldRenderer = renderer;
-
-          if (renderer) {
-            this.$.overlay.setProperties({owner: this, renderer: renderer});
-          }
         }
 
         disconnectedCallback() {
@@ -232,6 +228,7 @@
 
         _openedChanged(opened) {
           if (opened) {
+            this.$.overlay.setProperties({owner: this, renderer: this.renderer});
             this.$.overlay.template = this.querySelector('template');
           }
           this.$.overlay.opened = opened;

diff --git a/test/vaadin-dialog_renderer-test.html b/test/vaadin-dialog_renderer-test.html
@@ -57,6 +57,15 @@
         }).to.throw(Error);
         expect(dialog._contentTemplate).to.be.not.ok;
       });
+
+      it('should not render the content of renderer function if the dialog is not opened', () => {
+        dialog.renderer = (root, dialog) => {
+          const div = document.createElement('div');
+          div.textContent = 'The content of the dialog';
+          root.appendChild(div);
+        };
+        expect(overlay.textContent).to.include('');
+      });
     });
 
     describe('renderer function with template', () => {