Add ability to mark child element as draggable #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By adding a class "draggable" to an element, user can mark it as an area from which the dialog can be dragged. Part of vaadin/vaadin-dialog-flow#165
|
|
DiegoCardoso
commented
Mar 4, 2020
| e.preventDefault(); | ||
| const isDraggable = e.target.classList.contains('draggable'); | ||
| if ((isResizerContainer && !isResizerContainerScrollbar) || isContentPart || isDraggable) { | ||
| !isDraggable && e.preventDefault(); |
There was a problem hiding this comment.
This is needed to not prevent default for the case of, for instance, selection of the word by double clicking.
I couldn't come up with a test case to cover that case.
DiegoCardoso
commented
Mar 4, 2020
| @@ -27,8 +27,9 @@ | |||
| const isResizerContainer = e.target === resizerContainer; | |||
| const isResizerContainerScrollbar = e.offsetX > resizerContainer.clientWidth || e.offsetY > resizerContainer.clientHeight; | |||
| const isContentPart = e.target === this.$.overlay.$.content; | |||
| if ((isResizerContainer && !isResizerContainerScrollbar) || isContentPart) { | |||
| e.preventDefault(); | |||
| const isDraggable = e.target.classList.contains('draggable'); | |||
There was a problem hiding this comment.
Using draggable as class name, but the name and/or using it as a class or attribute is up for discussion.
tomivirkki
approved these changes
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding a class "draggable" to an element, user can mark it as an area from which the dialog can be dragged.
Part of vaadin/vaadin-dialog-flow#165