Add scrollable dialog demo #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samiheikki
force-pushed
the
fix/scrollable-dialog-demo
branch
from
a94f0e6
to
947b5b0
Compare
yuriy-fix
approved these changes
Jul 11, 2018
There was a problem hiding this comment.
Should this demo be scrollable on all possible devices?
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
limonte
approved these changes
Jul 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to "Guidelines for component examples": Add scrollable dialog, with a fixed button footer and max-height (doesn’t grow bigger than the browser viewport)
This change is