Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Polymer 3 Modulizer compatibility #7

Merged
merged 3 commits into from
Mar 26, 2018
Merged

Conversation

web-padawan
Copy link
Member

@web-padawan web-padawan commented Mar 20, 2018

Fixes #6


This change is Reviewable

@web-padawan web-padawan changed the title Ensure Polymer 3 Modulizer compatibility [WIP] Ensure Polymer 3 Modulizer compatibility Mar 20, 2018
@web-padawan web-padawan changed the title [WIP] Ensure Polymer 3 Modulizer compatibility Ensure Polymer 3 Modulizer compatibility Mar 20, 2018
@web-padawan web-padawan force-pushed the p3-preview-dev branch 4 times, most recently from 041da9e to a9731c1 Compare March 22, 2018 07:45
@yuriy-fix
Copy link
Contributor

:lgtm:


Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@platosha
Copy link
Contributor

Reviewed 6 of 6 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


test/basic.html, line 50 at r2 (raw file):

        fixture('default');
        // wait for usage statistics to load
        setTimeout(done, 100);

BTW this is not clean, magic timeout value. Not a blocker, can fix later.


Comments from Reviewable

@platosha
Copy link
Contributor

:lgtm:


Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

@tomivirkki
Copy link
Member

:lgtm:


Reviewed 1 of 2 files at r1, 6 of 6 files at r2.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

@tomivirkki tomivirkki merged commit 6d10147 into p3-preview Mar 26, 2018
@tomivirkki tomivirkki deleted the p3-preview-dev branch March 26, 2018 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants