This repository has been archived by the owner on Aug 22, 2021. It is now read-only.
Fixed end of line problem with gulp-html-extract plugin on Windows. A… #143
+14
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Pull Request Test Coverage Report for Build 1080
💛 - Coveralls |
limonte
reviewed
Jul 3, 2018
.gitignore
Outdated
| @@ -1,4 +1,5 @@ | |||
| bower_components | |||
| node_modules | |||
| package-lock.json | |||
| coverage | |||
| yarn.lock | |||
| coverage | |||
There was a problem hiding this comment.
nit:
this red symbol means that there's no final newline in this file.
To fix it and prevent such issues in future I recommend this VS Code setting:
"files.insertFinalNewline": true,
…dded yarn.lock to gitignore.
sohrabtaee
force-pushed
the
fix/windows-eol-problem
branch
from
9c3877e
to
e6d3979
Compare
limonte
approved these changes
Jul 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed end of line problem with gulp-html-extract plugin on Windows.
Added yarn.lock to gitignore.
This change is