Skip to content
This repository has been archived by the owner on Aug 22, 2021. It is now read-only.

Update entry points titles #150

Merged
merged 2 commits into from
Jul 24, 2018
Merged

Update entry points titles #150

merged 2 commits into from
Jul 24, 2018

Conversation

yuriy-fix
Copy link
Contributor

@yuriy-fix yuriy-fix commented Jul 23, 2018

@coveralls
Copy link

coveralls commented Jul 23, 2018

Pull Request Test Coverage Report for Build 1117

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 1113: 0.0%
Covered Lines: 6
Relevant Lines: 6

💛 - Coveralls

Copy link
Contributor

@platosha platosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 4 unresolved discussions (waiting on @YuriyVaadin)


README.md, line 80 at r1 (raw file):

Vaadin components use the Lumo theme by default.

To use Material theme, import the correspondent file from `material` folder.

BTW the Material theme.


README.md, line 84 at r1 (raw file):

## Entry points

  Unstyled component.

Let us remove unstyled components from this list?


README.md, line 88 at r1 (raw file):

- `src/component-name.html`

  Component with Lumo theme.

Colons : would make more sense than the dots . in the end


README.md, line 88 at r1 (raw file):

- `src/component-name.html`

  Component with Lumo theme.

The component, the Lumo theme


README.md, line 91 at r1 (raw file):

- `theme/lumo/component-name.html`

  Component with Material theme.

The component, the Material theme

Copy link
Contributor Author

@yuriy-fix yuriy-fix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 4 unresolved discussions (waiting on @YuriyVaadin)


README.md, line 80 at r1 (raw file):

Previously, platosha (Anton Platonov) wrote…

BTW the Material theme.

Updated.


README.md, line 84 at r1 (raw file):

Previously, platosha (Anton Platonov) wrote…

Let us remove unstyled components from this list?

Removed.


README.md, line 88 at r1 (raw file):

Previously, platosha (Anton Platonov) wrote…

Colons : would make more sense than the dots . in the end

Added.


README.md, line 88 at r1 (raw file):

Previously, platosha (Anton Platonov) wrote…

The component, the Lumo theme

Updated.


README.md, line 91 at r1 (raw file):

Previously, platosha (Anton Platonov) wrote…

The component, the Material theme

Updated.

Copy link
Contributor

@platosha platosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Member

@web-padawan web-padawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@yuriy-fix yuriy-fix merged commit db41787 into master Jul 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants