-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
Pull Request Test Coverage Report for Build 1117
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 4 unresolved discussions (waiting on @YuriyVaadin)
README.md, line 80 at r1 (raw file):
Vaadin components use the Lumo theme by default. To use Material theme, import the correspondent file from `material` folder.
BTW the Material theme
.
README.md, line 84 at r1 (raw file):
## Entry points Unstyled component.
Let us remove unstyled components from this list?
README.md, line 88 at r1 (raw file):
- `src/component-name.html` Component with Lumo theme.
Colons :
would make more sense than the dots .
in the end
README.md, line 88 at r1 (raw file):
- `src/component-name.html` Component with Lumo theme.
The component, the Lumo theme
README.md, line 91 at r1 (raw file):
- `theme/lumo/component-name.html` Component with Material theme.
The component, the Material theme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 4 unresolved discussions (waiting on @YuriyVaadin)
README.md, line 80 at r1 (raw file):
Previously, platosha (Anton Platonov) wrote…
BTW
the Material theme
.
Updated.
README.md, line 84 at r1 (raw file):
Previously, platosha (Anton Platonov) wrote…
Let us remove unstyled components from this list?
Removed.
README.md, line 88 at r1 (raw file):
Previously, platosha (Anton Platonov) wrote…
Colons
:
would make more sense than the dots.
in the end
Added.
README.md, line 88 at r1 (raw file):
Previously, platosha (Anton Platonov) wrote…
The component, the Lumo theme
Updated.
README.md, line 91 at r1 (raw file):
Previously, platosha (Anton Platonov) wrote…
The component, the Material theme
Updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved
Connected to https://github.com/vaadin/components-team-tasks/issues/376
This change is