Skip to content
This repository has been archived by the owner on Aug 22, 2021. It is now read-only.

hello .editorconfig #192

Merged
merged 1 commit into from
Jan 9, 2019
Merged

hello .editorconfig #192

merged 1 commit into from
Jan 9, 2019

Conversation

lkraav
Copy link
Contributor

@lkraav lkraav commented Jan 2, 2019

Editors could get the right idea from the start. Any reason why not?


This change is Reviewable

@CLAassistant
Copy link

CLAassistant commented Jan 2, 2019

CLA assistant check
All committers have signed the CLA.

@web-padawan
Copy link
Member

Thanks for the PR! Personally I like the .editorconfig though haven't used it for a while.
Once the team is back from holidays, we will discuss whether we want to use it or not.

@lkraav
Copy link
Contributor Author

lkraav commented Jan 2, 2019

I searched your GH org for prior art https://github.com/search?q=org%3Avaadin+.editorconfig&type=Code and even though only 4 matches and nearly all the same, other than some comments, ended up picking what looked like the cleanest https://github.com/vaadin/base-starter-angular/blob/7dbd434db2c2c36807533f018c45c62f3837cf7f/.editorconfig for the base.

As far as I can tell, all web components are already following this format (I admit, no detail analysis has been run), so making these conventions explicit shouldn't cause any discomfort.


[*.md]
max_line_length = off
trim_trailing_whitespace = false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why trailing whitespaces should be allowed in md files?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a matter fact, I have no idea, was curious about this myself. But I thought since I think all GH searches through your repos had this set, maybe you guys specifically somewhat agreed on this already.

OTOH, it could also be some kind of a boilerplate default that I'm not aware of?

Google pointed me to editorconfig/editorconfig-vscode#153

When I add 2 spaces to the end of a line to create a markdown line break and then save the file, the trailing spaces are removed.

So apparently trailing whitespace logic is part of MD.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, thanks @lkraav!

@limonte limonte merged commit f95e1a0 into vaadin:master Jan 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants